Proposals / #1001

Use the full BOOL return for the Mac graphics-state predicate

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra vmac 111 · 3cfe190

Mac0018a2ca explicitly returns fullEAX0/1, and both actual packet-update callers test fullEAX. Replace the current one-byte bool return with existing four-byte BOOL. Preserve pUnit, one DWORD Stack4 formal, cdecl and all locals. Complete target, both caller paths and actual flags-pointer producer match separate assembly; the original Windows counterpart has the same word scan and alreadyBOOL. Caller register restoration is proved across all paths. No pending-helper, shared field, base/extended alias, union/layout, array extent, input type, name or behavior change.

Changes 1, applied together

1. Set prototype mac 0x0018a2ca

   signaturebool STATES_HasAnyGfxFlag(D2UnitStrc * pUnit)→BOOL STATES_HasAnyGfxFlag(D2UnitStrc * pUnit)
   convention__cdecl