Proposals / #1007

Recover the MCP connection-state full Boolean accessors

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra v1846 · 3cfe190

The only recorded state writer in each build is the four-byte setter. Every real call supplies literal0 or1: send/reset/pump paths pass0 and incoming0x02 passes1. The Mac getter returns the same fullDWORD and its sole executable consumer tests fullEAX. Recover its BOOL result and type both setters' existing four-byte input as BOOL. Preserve all selected names, parameter slots and existing conventions; Windows getter already has BOOL and stays read-only. Raw complete bodies plus all six writer sites and both fullEAX consumers are checked; Windows245bytes also match the original expected-SHA PE. No global/name/packet-layout or behavior change.

Changes 3, applied together

1. Set prototype mac 0x002ccba7

   signatureundefined MCPSTATE_GetConnectionEstablished(void)→BOOL MCPSTATE_GetConnectionEstablished(void)
   conventionunknown

2. Retype variable mac 0x002ccbb8 Stack[0x4]

   typeundefined4→BOOL

3. Retype variable win 0x00449c20 Stack[0x4]

   typeundefined4→BOOL