Proposals / #1010

Recover the full-width Boolean result of the Mac class-skill predicate

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra vmac 111 · 3cfe190

Mac00188c31 stores the scalar helper result through the existing output pointer, compares it with7, then SETNE AL/MOVZX EAX,AL before its sole plain RET. Every normal return is a full-width0 or1, and the sole actual caller immediately TESTs all32bits of EAX. Recover BOOL while preserving the chosen function/parameter/local names, two existing DWORD stack inputs and __cdecl convention. Complete native caller proves a nonnull local output address and the scalar skill-id source. No pairing, table layout, diagnostic-helper interface or behavior change is claimed.

Changes 1, applied together

1. Set prototype mac 0x00188c31

   signatureundefined SKILLS_IsClassSkill(int32_t nSkillId, int32_t * pCharClass)→BOOL SKILLS_IsClassSkill(int32_t nSkillId, int32_t * pCharClass)
   convention__cdecl