Proposals / #1021

Persist the timestamped log filename prefix as a C-string pointer

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra v1846 · 3cfe190

OpenLogFileWithTimestamp receives a C-string address in ECX, but szFilePrefix is explicitly undefined4. The complete body captures ECX in EBX and pushes that exact base for the second %s in the original format %s%s%02d%02d%02d.txt. All three actual callers forward the same incoming byte-string bases; the slot caller independently compares and NUL-copies that string, while the other callers pass their same bases through a byte-string lookup. Persist char * at ECX:4, preserving the chosen szFilePrefix name, all other inputs, FILE * return and ordinary fastcall. resolvedType already reports char *; this is an explicit raw-slot typing correction, with no measured decompile/export/byte-match gain or runtime/file behavior claim.

Changes 1, applied together

1. Retype variable win 0x0040ebd0 ECX

   typeundefined4→char *