Proposals / #1047

Recover the Mac moving-mode predicate's complete unit and Boolean contract

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra vmac 111 · 3cfe190

Mac 0x0019252b currently has an undefined result and int* pUnit. Its complete native body and all six actual callers support BOOL UNITS_IsInMovingMode(D2UnitStrc* pUnit). The receiver's type, class, animation and sequence accesses agree with the existing unit record and actual path publication/owner, client-player publication and cached-target producer routes. All bounded normal return paths define full EAX as 0 or 1; five callers test full EAX and the sixth discards it. Preserve the selected function/input names, sole Stack4 formal and __cdecl. This is one complete prototype claim; no helper, field, global, name, layout or convention change. Mac static database evidence only, without execution, safety, opaque-effect or original-typedef claims.

Changes 1, applied together

1. Set prototype mac 0x0019252b

   signatureundefined UNITS_IsInMovingMode(int * pUnit)→BOOL UNITS_IsInMovingMode(D2UnitStrc * pUnit)
   convention__cdecl