Proposals / #1050

QUESTLOG_HitTestOpenButton returns bool, not int32_t

checked · by Nugwa628 · submitted 2026-11-02

Both exits set AL only: 004a26a5 MOV AL,1 / 004a26a7 RET and 004a26a8 XOR AL,AL / 004a26aa RET. The one caller tests the byte: 004a3f82 CALL 0x004a2690 / 004a3f87 TEST AL,AL / 004a3f89 JE. The int32 return is Ghidra's CONCAT31 of stale upper bytes (the undefined3 dwHitResult register local); same shape as QUESTLOG_HitTestCloseButton 004a2610. Return type only; parameter names and storage unchanged. Resubmission of #1017, which went stale when the parameters were renamed. Recompiled with VC8, 004a2690 then matches byte for byte.

Changes 1, applied together

1. Set prototype win 0x004a2690

   signatureint32_t QUESTLOG_HitTestOpenButton(int32_t nPanelY, int32_t nPanelX)→bool QUESTLOG_HitTestOpenButton(int32_t nPanelY, int32_t nPanelX)
   convention__cdecl