Proposals / #1053

SID_SetReadyFlag returns BOOL, not void

checked · by Nugwa628 · submitted 2026-11-02

The whole function: 00520ad0 MOV EAX,1 / 00520ad5 MOV dword ptr [0x00882528],EAX / 00520ada RET. EAX holds 1 at its only RET; a void store would compile to MOV dword ptr [0x00882528],1 with no EAX load, so the value is the function's result (return TRUE after setting the flag). Callers ignore it (0051c4d8 CALL 0x00520ad0 / 0051c4dd PUSH 0). Same shape as #999. Return type only. Recompiled with VC8, 00520ad0 then matches byte for byte.

Changes 1, applied together

1. Set prototype win 0x00520ad0

   signaturevoid SID_SetReadyFlag(void)→BOOL SID_SetReadyFlag(void)
   convention__stdcall