Proposals / #1060

SKILLDESC_DescLine41_AppendStrings returns BOOL, not void

checked · by Nugwa628 · submitted 2026-11-02

004ecb10 CMP CX,0x1506 / 004ecb15 JE 0x004ecb7b and 004ecb17 CMP DI,0x1506 / 004ecb1c JE 0x004ecb7b go to 004ecb7b XOR EAX,EAX / 004ecb7d RET (returns 0); the normal exit is 004ecb75 MOV EAX,1 / 004ecb7a RET. Caller: 004eeac2 CALL 0x004ecb10 (value unused). Same shape as #999. Return type only; parameters stay in the DB's register storage. Recompiled with VC8, 004ecb10 then matches byte for byte.

Changes 1, applied together

1. Set prototype win 0x004ecb10

   signaturevoid SKILLDESC_DescLine41_AppendStrings(uint16_t wDescTextA, WCHAR * wszText, uint16_t wDescTextB)→BOOL SKILLDESC_DescLine41_AppendStrings(uint16_t wDescTextA, WCHAR * wszText, uint16_t wDescTextB)
   convention__cdecl