Proposals / #1114

Widen the complete Mac equipped-trade predicate result to BOOL

checked · by Commit-Will · submitted 2026-11-03

Mac00212834 currently declares bool1, but every normal RET has a fullEAX literal0/1 definition. Recover existing BOOL4 while preserving both selected formals: unused pGameStrc/Stack4 and genuine pUnit/Stack8, their precise types/names, arity, cdecl, noVarArgs and all7locals. Complete100B37instruction fresh Mac raw equals separate complete assembly and exact ownership/nativeCFG. Conservative ordinaryCALL GP clobbers still leave only local XOR0/MOV1 result roots. This follows the return-width rule, without treating metadata-only callers as ABI or consumer proof. All qualifying captures were freshly reacquired after root review of registry-only drift; quarantined captures remain excluded. No opaque effects/cleanup/preservation, private-word initialization, item/game semantics, runtime safety, original typedef/MachO identity/execution or source/build/matching gain. Any actual contradiction/refusal holds this original entire contract with no reduced variant.

Changes 1, applied together

1. Set prototype mac 0x00212834

   signaturebool PLAYERTRADE_CheckNoEquippedTradeItems(D2GameStrc * pGameStrc, D2UnitStrc * pUnit)→BOOL PLAYERTRADE_CheckNoEquippedTradeItems(D2GameStrc * pGameStrc, D2UnitStrc * pUnit)
   convention__cdecl