Proposals / #1142

Mac AI_Monster_ExecuteAiCommands: bool __cdecl (pGame, pUnit) prototype

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x002a4b1a is "undefined (void)", convention unknown. The only stack args read are [EBP+8] (pGame, e.g. 0x002a4bc4/0x002a4ced) and [EBP+0xc] (pUnit, 0x002a4b29, passed to AI_CreateCmdIfNotExists-style getter 0x001a18c3); no [EBP+0x10]; no ECX/EDX on entry; plain RET at 0x002a4eed. Caller AI_Fn1_Npc stores [ESP+4]=EBX, [ESP]=EDI then CALL at 0x002a54fb and TEST AL,AL. So it is a 2-arg cdecl returning bool. Windows twin 0x005e6ae0 returns bool and declares a third pAiParam that the Mac body never reads.

Changes 1, applied together

1. Set prototype mac 0x002a4b1a

   signatureundefined AI_Monster_ExecuteAiCommands(void)→bool AI_Monster_ExecuteAiCommands(D2GameStrc * pGame, D2UnitStrc * pUnit)
   conventionunknown→__cdecl