Proposals / #1149

Mac SKILL_ApplyStunState: void __cdecl (pGame, pUnit, pTarget, eState) prototype

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x0026e447 is "undefined (void)", convention unknown. Reads [EBP+8] (pGame: [EBX+0xa8] game frame at 0x0026e4c7), [EBP+0x10] (target unit: CMP [EDI],1 and GetStatsByState(EDI,..)), [EBP+0x14] (passed as eState to GetStatsByState at 0x0026e4c2); [EBP+0xc] is not read; plain RET 0x0026e5f7. Sole caller SKILLBAR_SrvStFn41_LeapAttack stores [ESP]=pGame, [ESP+4]=EDI, [ESP+8]=ESI, [ESP+0xc]=0x64 before CALL at 0x00252776, i.e. 4 cdecl args. Windows twin 0x00570420 is void with (this, pUnit, eD2States eState).

Changes 1, applied together

1. Set prototype mac 0x0026e447

   signatureundefined SKILL_ApplyStunState(void)→void SKILL_ApplyStunState(D2GameStrc * pGame, D2UnitStrc * pUnit, D2UnitStrc * pTarget, eD2States eState)
   conventionunknown→__cdecl