Proposals / #1153

Mac AI_BAAL_IsSkillPowerful: BOOL __fastcc (D2UnitStrc* pUnit, D2SkillStrc* pSkill) prototype

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x001a11ce is "undefined (void)", convention unknown. Entry: EDI=ECX (unit), EBX=EDX (skill, NULL-checked, passed with file/line 0x131 to 0x0018732e, then (EDI, EBX, 1) to 0x0018608e skill-level getter); no [EBP+n] reads; returns ESI = 0/1 via MOV EAX,ESI; plain RET 0x001a125c. Sole caller AI_CheckSpecialSkillsOnPrimeEvil sets ECX=unit, EDX=EAX (skill from 0x0018e7ff) and tests EAX (0x001a1141-0x001a114a). Same two values as Windows twin 0x005fc070 BOOL (D2UnitStrc* pUnit, D2SkillStrc* pSkill).

Changes 1, applied together

1. Set prototype mac 0x001a11ce

   signatureundefined AI_BAAL_IsSkillPowerful(void)→BOOL AI_BAAL_IsSkillPowerful(D2UnitStrc * pUnit, D2SkillStrc * pSkill)
   conventionunknown→__fastcc