Proposals / #1157

Mac MONSTERAI_CheckAdjacentUnit: type as pfnPetsForEachCallback (void __cdecl 4 args)

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x002a04bc is "undefined (void)", convention unknown. Its only code references are as the callback argument of PetsForEach (0x001fa77f, pfnCallback is pfnPetsForEachCallback = void __cdecl (D2GameStrc* pGame, D2UnitStrc* pUnit, D2UnitStrc* pPetUnit, void* pCallbackArg)): AI_Pet_ExecuteMovementBehavior loads its address (0x002a1211/0x002a1217) into [ESP+8] for the CALL at 0x002a1228. The body reads [EBP+0x10] (pet unit, compared with and passed to 0x001a5190) and [EBP+0x14] (context: [ESI] unit, writes [ESI+4], increments [ESI+8]); [EBP+8]/[EBP+0xc] unused; no EAX result; plain RET 0x002a04ed. Prototype set to the funcdef's.

Changes 1, applied together

1. Set prototype mac 0x002a04bc

   signatureundefined MONSTERAI_CheckAdjacentUnit(void)→void MONSTERAI_CheckAdjacentUnit(D2GameStrc * pGame, D2UnitStrc * pUnit, D2UnitStrc * pPetUnit, void * pCallbackArg)
   conventionunknown→__cdecl