Proposals / #1162

Mac MONSTERAI_FindRandomWalkPoint: BOOL __cdecl (pGame, pUnit) prototype

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x0025c5e8 is "undefined (void)", convention unknown. The only stack argument the body reads is [EBP+0xc] (unit: passed to UNITS_GetRoom 0x0018f1ae at 0x0025c5f7, [EDI] unit-type check; also 0x0025c6c3, 0x0025c736); [EBP+8] (pGame slot) and anything above +0xc are never read; no ECX/EDX use on entry; returns EAX; plain RET 0x0025c75d. The caller AI_Monster_CastItemEffectSkill stores the unit at [ESP+4] (0x0025c981) and tests EAX after the CALL at 0x0025c985. Windows twin 0x005fd850 is BOOL (pGame, pUnit, eD2Skills nSkillId, int32_t nSubSkill); the skill arguments are not used by the Mac body, so only the first two are declared.

Changes 1, applied together

1. Set prototype mac 0x0025c5e8

   signatureundefined MONSTERAI_FindRandomWalkPoint(void)→BOOL MONSTERAI_FindRandomWalkPoint(D2GameStrc * pGame, D2UnitStrc * pUnit)
   conventionunknown→__cdecl