Proposals / #1185

Mac SKILLAMA_SrvStFn04_ArrowAttack: BOOL __cdecl SrvStFunc (pGame, pUnit, eSkill, nSkillLvl)

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x00245d19 is "undefined (void)", convention unknown. Skill SrvStFunc: reads [EBP+8] (pGame) and [EBP+0xc] (pUnit: SKILLS_CheckThrowableAmmo 0x0026a193, then (pGame, pUnit) to 0x001fd493/0x001fd9ec); returns 1 or 0 in EAX; plain RET 0x00245d5a; no ECX/EDX on entry. It belongs to the same SrvStFunc table as Mac SKILLS_SrvStFn01_Attack (0x0026a928, BOOL __cdecl (D2GameStrc*, D2UnitStrc*, eD2Skills, int32_t)), and SKILLAMA_SrvStFn08_Strafe calls it directly. Windows twin 0x005da8b0 has the same 4-arg table signature.

Changes 1, applied together

1. Set prototype mac 0x00245d19

   signatureundefined SKILLAMA_SrvStFn04_ArrowAttack(void)→BOOL SKILLAMA_SrvStFn04_ArrowAttack(D2GameStrc * pGame, D2UnitStrc * pUnit, eD2Skills eSkill, int32_t nSkillLvl)
   conventionunknown→__cdecl