Proposals / #1187

Mac SKILLAMA_SrvStFn07_Impale: BOOL __cdecl SrvStFunc (pGame, pUnit, eSkill, nSkillLvl)

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x00245f58 is "undefined (void)", convention unknown. Skill SrvStFunc reading exactly the four table arguments: [EBP+8] (pGame, 0x00245fb8), [EBP+0xc] (pUnit, 0x00245fb5), [EBP+0x10] (skill id, sign-tested at 0x00245f74), [EBP+0x14] (skill level, 0x00246005); no ECX/EDX on entry (both loaded from the frame before use); plain RET. Same table slot type as Mac SKILLS_SrvStFn01_Attack (0x0026a928, BOOL __cdecl (D2GameStrc*, D2UnitStrc*, eD2Skills, int32_t)); Windows twin 0x005dab40 has the same 4-arg signature.

Changes 1, applied together

1. Set prototype mac 0x00245f58

   signatureundefined SKILLAMA_SrvStFn07_Impale(void)→BOOL SKILLAMA_SrvStFn07_Impale(D2GameStrc * pGame, D2UnitStrc * pUnit, eD2Skills eSkill, int32_t nSkillLvl)
   conventionunknown→__cdecl