Proposals / #1194

Mac Q34_OnNihlathakAI: void __cdecl (D2GameStrc* pGame) prototype

rejected · by KierTaylor · submitted 2026-11-05, rejected 2026-11-05

Mac 0x00240859 is "undefined (void)", convention unknown. Reads only [EBP+8] and passes it with 0x22 to GetQuestDataByQuestNoInternal (0x0021326f, (D2GameStrc* pGame, eD2QuestsInternal)) at 0x00240874, then may call 0x002146d5 on the quest data; no ECX/EDX on entry; no result; plain RET 0x002408bc. Matches Windows twin 0x0058bc40 void Q34_OnNihlathakAI(pGame).

Changes 1, applied together

1. Set prototype mac 0x00240859

   signatureundefined Q34_OnNihlathakAI(void)→void Q34_OnNihlathakAI(D2GameStrc * pGame)
   conventionunknown→__cdecl