Proposals / #1197

Mac Q32_PlayCompletionSound: BOOL __cdecl fpExecuteOnUnitFunction (pGame, pUnit, pArg)

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x0023c981 is "undefined (void)", convention unknown. Its only code use is as the pfnCallback (fpExecuteOnUnitFunction = BOOL __cdecl (D2GameStrc*, D2UnitStrc*, int32_t)) of IteratePlayerOrMonsterUnits (0x0027a083): Q32_OnBarricadeDestroyed loads its address into [ESP+0xc] at 0x0023c833/0x0023c839 before CALL 0x0027a083 at 0x0023c84c. The body reads [EBP+8] (game: byte +0x6d act) and [EBP+0xc] (unit: passed to 0x00191451 and as player to 0x0027976c), ignores the third, returns 0 (XOR EAX,EAX); plain RET 0x0023c9d7. Windows twin 0x005887f0 BOOL (pGame, D2UnitStrc* pUnit, void* pArg).

Changes 1, applied together

1. Set prototype mac 0x0023c981

   signatureundefined Q32_PlayCompletionSound(void)→BOOL Q32_PlayCompletionSound(D2GameStrc * pGame, D2UnitStrc * pUnit, void * pArg)
   conventionunknown→__cdecl