Proposals / #1198

Mac Q32_PropagateCompleteToParty: BOOL __cdecl fpExecuteOnUnitFunction (pGame, pUnit, pArg)

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x0023c856 is "undefined (void)", convention unknown. Its only code use is as the pfnCallback (fpExecuteOnUnitFunction = BOOL __cdecl (D2GameStrc*, D2UnitStrc*, int32_t)) argument of IteratePlayerOrMonsterUnits (0x0027a083): Q32_OnBarricadeDestroyed loads its address into [ESP+0xc] at 0x0023c7f1/0x0023c7f7 before CALL 0x0027a083 at 0x0023c810. The body reads [EBP+8] (game: act byte +0x6d, arg 1 of 0x00276faf) and [EBP+0xc] (unit: 0x00191451, 0x0027b111), ignores the third, returns 0; plain RET. Windows twin 0x005887a0 BOOL (pGame, D2UnitStrc* pUnit, void* pArg).

Changes 1, applied together

1. Set prototype mac 0x0023c856

   signatureundefined Q32_PropagateCompleteToParty(void)→BOOL Q32_PropagateCompleteToParty(D2GameStrc * pGame, D2UnitStrc * pUnit, void * pArg)
   conventionunknown→__cdecl