Proposals / #1200

Mac Q32_IncrementBarricadeGroupKills: void __fastcc (pQuestData ECX, pUnit EDX)

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x00245256 is "undefined (void)", convention unknown. Entry: ESI=ECX and (ESI, EDX) are passed as [ESP]/[ESP+4] to Q32_FindBarricadeGroup (0x0023b1e9, int32_t (D2QuestDataStrc* pQuestData, D2UnitStrc* pUnit)) at 0x00245266; then [ESI+0x18] (pQuestSpecificData) kill counter +0x114[group] is incremented and +0x108[group] set at 5. No [EBP+n] reads; no result; plain RET 0x00245293. Mac clang fastcc (ECX, EDX).

Changes 1, applied together

1. Set prototype mac 0x00245256

   signatureundefined Q32_IncrementBarricadeGroupKills(void)→void Q32_IncrementBarricadeGroupKills(D2QuestDataStrc * pQuestData, D2UnitStrc * pUnit)
   conventionunknown→__fastcc