Proposals / #1208

Mac Q35_ResetAncientsArena: void __fastcc (pGame, pQuestData, D2QuestDataA5Q5Strc* pQuestSpecificData)

approved · by KierTaylor · submitted 2026-11-05, approved 2026-11-05

Mac 0x00240be3 is "undefined (void)", convention unknown. Entry: ECX is used as the game (EDI=ECX, [ESP]=ECX for FindUnitFromTable 0x0027905c at 0x00240c1a); EDX saved to [EBP-0x3c] and later read as quest data ([EDX+4] = D2QuestDataStrc.pGame passed to 0x0027905c at 0x00240d0d-0x00240d22); [EBP+8] is the A5Q5 block (byte flags +0x2f.., unit GUIDs +0x2c.., cleared +0x3c..). Plain RET 0x00240d7f. Caller Q35_SpawnAncientTimer sets EDX=EDI (quest data), ECX=[EDX+4] (pGame), [ESP]=ESI (quest-specific block) before CALL at 0x00240b18.

Changes 1, applied together

1. Set prototype mac 0x00240be3

   signatureundefined Q35_ResetAncientsArena(void)→void Q35_ResetAncientsArena(D2GameStrc * pGame, D2QuestDataStrc * pQuestData, D2QuestDataA5Q5Strc * pQuestSpecificData)
   conventionunknown→__fastcc