Proposals / #1215

Mac INTRONPC_FillInPacketWithIntroNpcIdsInAct: BOOL __cdecl (pGame, pUnit, eAct nActNo)

rejected · by KierTaylor · submitted 2026-11-05, rejected 2026-11-05

Mac 0x00215e54 is "undefined (void)", convention unknown. Reads [EBP+8] (game: byte +0x6d difficulty), [EBP+0xc] (unit: passed to 0x00191451 player data), and byte [EBP+0x10] (act number, MOVZX then bounded <=4 and used as a jump-table index at 0x00215e86-0x00215e8f); no ECX/EDX on entry; plain RET. Matches Windows twin 0x00545100 BOOL (pGame, D2UnitStrc* pUnit, eAct nActNo).

Changes 1, applied together

1. Set prototype mac 0x00215e54

   signatureundefined INTRONPC_FillInPacketWithIntroNpcIdsInAct(void)→BOOL INTRONPC_FillInPacketWithIntroNpcIdsInAct(D2GameStrc * pGame, D2UnitStrc * pUnit, eAct nActNo)
   conventionunknown→__cdecl