Proposals / #1232

Mac SKILLBAR_ApplyWhirlwindDamage: void __fastcc (pGame, pDamage, pUnit, pTarget, eSkill, nSkillLvl)

checked · by KierTaylor · submitted 2026-11-05

Mac 0x0024ce08 is "undefined (void)", convention unknown. Entry: ECX saved to [EBP-0x34] and passed as pGame to DAMAGE_CalculateOffensiveDamage (0x0027bbd0) at 0x0024d31c-0x0024d332; EBX=EDX passed as the damage block to SKILLASS_ApplyProgressiveDamageToTarget(pUnit, damage) at 0x0024ce23 (and OR byte [EBX],3 flags). Stack: [EBP+8] attacker (pUnit arg of both calls), [EBP+0xc] target (pTarget of DAMAGE_CalculateOffensiveDamage), [EBP+0x10]/[EBP+0x14] skill id and level (args 2-3 of SKILL_CalcMaxDamage 0x0018887b at 0x0024ce4b-0x0024ce64). No other stack reads; plain RET 0x0024d362. Windows twin 0x005d54b0 has six arguments too (pGame, D2DamageStrc* pDamage, D2UnitStrc* pUnit, eD2Skills eSkill, ...).

Changes 1, applied together

1. Set prototype mac 0x0024ce08

   signatureundefined SKILLBAR_ApplyWhirlwindDamage(void)→void SKILLBAR_ApplyWhirlwindDamage(D2GameStrc * pGame, D2DamageStrc * pDamage, D2UnitStrc * pUnit, D2UnitStrc * pTarget, eD2Skills eSkill, int32_t nSkillLvl)
   conventionunknown→__fastcc