Proposals / #1234

Mac Q31_SyncQuestProgress: rename unused callback arg nParam to nCallbackArg

checked · by KierTaylor · submitted 2026-11-05

Mac 0x00245294 is an fpExecuteOnUnitFunction callback (BOOL __cdecl (D2GameStrc*, D2UnitStrc*, int32_t)): Q31_Callback03_ChangedLevel passes its address as pfnCallback ([ESP+0xc]) to IteratePlayerOrMonsterUnits (0x0027a083) with pCallbackArg=0 ([ESP+8]) at 0x0023a4e7-0x0023a504. The body reads only [EBP+8] and [EBP+0xc]; the third parameter, still the generic default nParam, is that callback argument (unused here). Renamed by role.

Changes 1, applied together

1. Rename variable mac 0x00245294 Stack[0xc]

   namenParam→nCallbackArg