Proposals / #1237

Mac Q34_OnNihlathakAI: void __cdecl (D2GameStrc* pGame, D2UnitStrc* pUnit)

checked · by KierTaylor · submitted 2026-11-05

Resubmit of #1194 per review. Mac 0x00240859 reads only [EBP+8] (pGame, passed with 0x22 to GetQuestDataByQuestNoInternal at 0x00240874); no result; plain RET 0x002408bc. Its caller AITHINK_Fn1_Nihlathak stores [ESP+4] (0x002aed95) and [ESP] (0x002aed9c) before the CALL at 0x002aed9f, and the Windows caller sets both ECX and EDX, so the second arg is an unused pUnit. Windows twin 0x0058bc40.

Changes 1, applied together

1. Set prototype mac 0x00240859

   signatureundefined Q34_OnNihlathakAI(void)→void Q34_OnNihlathakAI(D2GameStrc * pGame, D2UnitStrc * pUnit)
   conventionunknown→__cdecl