Proposals / #1346

Type the affix candidate append helper's EDX parameter as D2MagicAffixTxt pointer

applied · by eejitgames · submitted 2026-11-06, applied 2026-11-06

Ghidra vwin 1971 · 9dc1ead

win 0x005c0d00 EDX pAffixTxt is int32_t but carries a D2MagicAffixTxt*. Sole caller 005c17c9 loads it from [EBP-0x1c] at 005c17c0. That slot is assigned the record base at 005c16d7 LEA EDI,[ESI-0x60] / 005c16da MOV [EBP-0x1c],EDI; the loop advances ESI by 0x90 at 005c17f7, matching sizeof(D2MagicAffixTxt). The helper stores EDX unchanged at candidate+count*8+4 (005c0d0a). The consumer reloads that pointer at 005c185e and reads frequency byte +0x82 and level dword +0x58 at 005c1863/186a and 005c1875, matching the existing struct. Retype only EDX; retain chosen names, custom register locations, return/count, and convention. Removes the caller's integer cast on pCurAffixTxt. No runtime test claimed.

Changes 1, applied together

1. Retype variable win 0x005c0d00 EDX

   typeint32_t→D2MagicAffixTxt *