Proposals / #1414

Restore the Mac dynamic-path room getter's pointer argument and result

checked · by eejitgames · submitted 2026-11-07

Mac00180e5e is undefined FUN_00180e5e(int pPath), but its complete11B body reads one stack pointer then returns [pointer+0x1c] unchanged in full EAX. Existing D2DynamicPathStrc.pRoom at0x1c is D2RoomStrc*. Its only executable caller0018f206 supplies the non-null dynamic path from unit+0x2c. Actual Windows counterpart00648a80 is GetRoom(D2DynamicPathStrc*)→D2RoomStrc*,13B, with the identical load; its RET4 differs from Mac's plainRET, so retain Mac cdecl. Restore typed input/result, preserving chosen pPath. Paired naming GetRoom was refused solely for lacking a module prefix; retain the Mac default name in this op and request paired naming in review. Full paired unit getters00620bb0/0018f1ae corroborate the producer and match halt line0x896. Stale Mac no-twin comments also need review.

Changes 1, applied together

1. Set prototype mac 0x00180e5e

   signatureundefined FUN_00180e5e(int pPath)→D2RoomStrc * FUN_00180e5e(D2DynamicPathStrc * pPath)
   convention__cdecl