Proposals / #1418

Restore the Mac room-list removal routine's paired void result

checked · by eejitgames · submitted 2026-11-08

Mac0018e452 still declares an undefined result, while the full290B body performs unit unlinking, allied-count/update-list work, flag clearing and a room reset. Paired Windows0064c370 is void RemoveUnitFromRoom(D2UnitStrc*) with the same operations and full221B body. Adopt that void contract while preserving the already-correct D2UnitStrc* input, chosen pUnit and Mac one-stack cdecl ABI. Both Mac exits were inspected: ordinaryRET or restored-frame tailJMP to the room clearer; neither deliberately constructs a common result. All27 incoming code references were read natively(26CALL,1JMP), with selected branch follow-ups and the complete132B existing-void tail caller. Do not infer a returned found-flag from scratch registers. Matching name/comment cleanup remains for review.

Changes 1, applied together

1. Set prototype mac 0x0018e452

   signatureundefined FUN_0018e452(D2UnitStrc * pUnit)→void FUN_0018e452(D2UnitStrc * pUnit)
   convention__cdecl