Proposals / #1448

Mac NPC_BeginInteraction: void __cdecl (pGame, pPlayer, pNpcUnit, pAi, nQuestActionType)

checked · by KierTaylor · submitted 2026-11-08

Resubmit of #1227 with a void return, as the reviewer asked. The early exit at 0x001d90fa leaves the NPC pointer in EAX, and the only caller (0x001ffbf0) ignores EAX. The five cdecl stack args are unchanged: [EBP+8] pGame, [EBP+0xc] player, [EBP+0x10] NPC, [EBP+0x14] AI block, byte [EBP+0x18] quest action. Windows twin 0x00572c10.

Changes 1, applied together

1. Set prototype mac 0x001d90d2

   signatureundefined NPC_BeginInteraction(void)→void NPC_BeginInteraction(D2GameStrc* pGame, D2UnitStrc* pPlayer, D2UnitStrc* pNpcUnit, D2MonsterAiStrc* pAi, uint8_t nQuestActionType)
   conventionunknown→__cdecl