Proposals / #1626

Correct the Mac path-advance routine's scalar movement-scale argument

checked · by eejitgames · submitted 2026-11-08

Mac00183964 currently types its second stack argument as D2DynamicPathStrc*32. Native00183abb reads the DWORD value, signedCMOVG chooses it only when positive (otherwise0x400), then IMUL/SAR use it directly to scale velocity. It is never dereferenced. All3 callers pass a scalar: server0x400 or client getter00071626's DWORD result. Windows00650840 forwards the same argument to006502d0, whose existingint32_t nStepScale and complete native body match the inlined Mac calculation. Retype only Stack8 toint32_t; preserve firstinput, returntype, cdecl and chosen names. The misleading pExternalPath name needs reviewer correction to nStepScale.

Changes 1, applied together

1. Retype variable mac 0x00183964 Stack[0x8]

   typeD2DynamicPathStrc *32→int32_t