Proposals / #1690

Restore the Mac player walk/run velocity output API and record type

checked · by eejitgames · submitted 2026-11-08

Mac0018f3fc has an untyped unused first argument, unnamed uint outputs, undefined result and integer pRecord. Native code indexes D2DataTableTxtStrc.pTxtCharStats/count(+bc4/+bc8) at196-byte stride, zero-extends WalkVelocity/RunVelocity bytes(+40/+41), and stores DWORDs through output slots c/10. Sole Maccaller001225de supplies a player pointer, classID and separate4B locals, then discards EAX. Complete Windows00620e40 has identical code/slots and an existingvoidAPI with int outputs. Restore those types/names and D2CharStatsTxt*pRecord; retain chosen nIndex/name and Maccdecl, not WinRET16.

Changes 2, applied together

1. Set prototype mac 0x0018f3fc

   signatureundefined FUN_0018f3fc(undefined4 param_1, int nIndex, uint * param_3, uint * param_4)→void FUN_0018f3fc(D2UnitStrc * pUnused, int nIndex, int * pWalkVelocity, int * pRunVelocity)
   convention__cdecl

2. Retype variable mac 0x0018f3fc EAX

   typeundefined4→D2CharStatsTxt *