Proposals / #1703

Name the Mac monster-scaling expansion and difficulty parameters

checked · by eejitgames · submitted 2026-11-08

Mac 0017d635's generic nParam and bParam are the expansion flag and difficulty byte. In caller 001d6f53, MOV ESI,[EBP+8] at 001d769c reloads its typed D2GameStrc* argument and dominates the argument-reading block. MOV EAX,[ESI+0x70] at 001d770d and MOVZX ECX,byte[ESI+0x6d] at 001d7710 read the existing bExpansion and nDifficulty fields, then pass them as arguments two and three at CALL 001d771f. The helper acts only for expansion==0 and difficulty!=0, selects a ratio by difficulty, and adds difficulty*25 to the monster level. Its independently paired Windows body 0063eef0 already calls these parameters bExpansion and byDifficulty. Rename only the two eligible generic Mac names to match. Preserve all types, byte width, ABI, chosen names and the pending signed-arithmetic edits in1702.

Changes 2, applied together

1. Rename variable mac 0x0017d635 Stack[0x8]

   namenParam→bExpansion

2. Rename variable mac 0x0017d635 Stack[0xc]

   namebParam→byDifficulty