Proposals / #594

Name the value parameter of the stat setters and their thunks

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

In STATLIST_SetStatValue and the functions that forward to it, the third parameter is the value being set: D2AddStatToStatsListEx passes its own nValue there. The thunks' last parameter is the layer word, named here after each thunk's target (nSubIndex on STATLIST_AddStatValue). Stack[0x10] of STATLIST_SetStatValue is left as low because the checks treat it as chosen.

Changes 6, applied together

1. Rename variable win 0x006270b0 Stack[0xc]

   namenParam→nValue

2. Rename variable win 0x00627810 Stack[0xc]

   namenParam→nValue

3. Rename variable win 0x00627250 Stack[0xc]

   namenParam→nValue

4. Rename variable win 0x00627250 Stack[0x10]

   namenParam2→nLayer

5. Rename variable win 0x006272a0 Stack[0xc]

   namenParam→nValue

6. Rename variable win 0x006272a0 Stack[0x10]

   namenParam2→nSubIndex