Proposals / #605

Name ITEMMOD_RollRandomValue's upper bound parameter

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

The parameter is the other end of the range beside nMin: the roll is RANDOM_RandomNumberSelector(seed, (nParam - low) + 1) + low, and equal bounds return without rolling. Its plate already reads the range as [nMin, nParam]. If the caller passes them reversed, the function swaps them, so nMax is the normal meaning, not a guarantee.

Changes 1, applied together

1. Rename variable win 0x0065e9e0 Stack[0x4]

   namenParam→nMax