Proposals / #634

Name the scale byte of the two damage builders, tested in the running game

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

DAMAGE_CalculateOffensiveDamage's last parameter scales the hit where 0x80 means 100% and 0 is taken as 0x80, and DAMAGE_CalculateAndApplyDamage forwards its own last parameter there. The name matches the byScale proposed on DAMAGE_CalculatePhysicalDamage, which receives it. nParam on 0057b7d0 is left alone because I have not settled whether it is a skill slot or a weapon slot.

Changes 2, applied together

1. Rename variable win 0x0057b7d0 Stack[0x10]

   namebParam→byScale

2. Rename variable win 0x0057dbf0 Stack[0xc]

   namebParam→byScale