Proposals / #642

Name the mode parameter of the unit mode packet senders, checked against live captures

rejected · by dtchitt · submitted 2026-11-01, rejected 2026-11-01

bParam1 on the senders of 0x0C, 0x0D, 0x0E, 0x0F and 0x10 is packet byte [6]. Each client handler passes that byte as the first argument of HandleMessage, which NET_D2GS_CLIENT_Incoming0x6D calls with a literal 7, the mode it sets. Captures from a running game fit: 804 0x0C samples carry 0x13 here on monsters, and 0x0D carries 0x12 and 0x13 on the player. Names I can't change through this tool, but which look wrong: HandleMessage's pTargetUid receives this mode, nNpcHitType on 0x0C is the unit type, and dwObjectState on 0x0E is the unit GUID.

Changes 5, applied together

1. Rename variable win 0x0053b430 Stack[0xc]

   namebParam1→nMode

2. Rename variable win 0x0053b470 Stack[0xc]

   namebParam1→nMode

3. Rename variable win 0x0053b4b0 Stack[0xc]

   namebParam1→nMode

4. Rename variable win 0x0053b570 Stack[0xc]

   namebParam1→nMode

5. Rename variable win 0x0053b520 Stack[0xc]

   namebParam1→nMode