REDIVIVUS

Proposals / #665

Name forwarded parameters: scrollbar style, client id, percent, golem version, port

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

Each of these generic parameters is passed through unchanged, apart from a truncating cast, to a callee parameter that already has a meaningful name, so it takes that name. Checked on the machine code: the argument position lines up with the callee's signature and the parameter is not overwritten first. D2WINTEXTBOX_SetScrollbarStyle reaches its callee by a tail JMP (EDX untouched), so its call_site evidence is the JMP address.

Changes 7, applied together

  1. Rename variable win 0x004fc720 EDX

    namenParam→nStyle
  2. Rename variable win 0x0052cbe0 ECX

    namenParam→nClientId
  3. Rename variable win 0x005cec90 Stack[0xc]

    namenParam→nPercent
  4. Rename variable win 0x0056ae50 Stack[0xc]

    namenParam→nVersion
  5. Rename variable win 0x00530270 EDX

    namedwParam→nDisconnectReason
  6. Rename variable win 0x004162a0 Stack[0xc]

    namenParam→nBufferOutputLength
  7. Rename variable win 0x0040e230 EDX

    namenParam→nPort