Proposals / #671

Name forwarded parameters in chat, sound, quest log and network helpers

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

Each parameter reaches a named callee parameter unchanged, and I checked the pushes and registers against the callee's signature in the machine code. Names follow the callee. NPCMENU_CloseScrollAndInteraction's nNpcGUID matches the name proposed on NPCMENU_CloseNpcInteraction, which it calls with the same value.

Changes 9, applied together

1. Rename variable win 0x0043e610 EDX

   namenParam→nLineStyle

2. Rename variable win 0x0043e5f0 EDX

   namenParam→nLineStyle

3. Rename variable win 0x004ca9c0 EDX

   namenParam→bForceStop

4. Rename variable win 0x004b3d10 ECX

   namenParam→nNpcGUID

5. Rename variable win 0x00420360 Stack[0x4]

   namenParam→nSubId

6. Rename variable win 0x004a26b0 Stack[0x4]

   namedwParam→bAdjustMouse

7. Rename variable win 0x004ca8d0 EDX

   namenParam→nSearchValue

8. Rename variable win 0x0051c190 EDX

   namenParam→nBufferOutputLength

9. Rename variable win 0x0053b240 ECX

   namenParam→nClientId