REDIVIVUS

Proposals / #680

Name forwarded parameters in Storm, zlib, window and server connection helpers

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

Each parameter reaches a named callee parameter unchanged, and I checked the pushes and registers against the callee's signature in the machine code. Names follow the callee, with three exceptions: nMsg on WndProcC because the checks have no u prefix for the callee's uMsg, nLen2 on ZLIB_Adler32Combine32 because a single 32-bit length is sign-extended into the callee's Lo and Hi, and bSeekOptimization on SFILE_InitializeFileSystem because its callee's own plate shows the value is a boolean gate (gbSFileSeekOptimization), so the stale chosen name dwThrottleDelay on that callee is not copied.

Changes 20, applied together

  1. Rename variable win 0x00406870 EDX

    namedwParam→bSeekOptimization
  2. Rename variable win 0x0047fbf0 ECX

    namenParam→nSize
  3. Rename variable win 0x00420cf0 Stack[0x8]

    namenParam1→nMsg
  4. Rename variable win 0x00420cf0 Stack[0xc]

    namenParam2→nWParam
  5. Rename variable win 0x00425700 Stack[0x8]

    namenParam2→nBitLength
  6. Rename variable win 0x00424f50 Stack[0xc]

    namenParam→nExponent
  7. Rename variable win 0x0052cc10 ECX

    namenParam→nClientId
  8. Rename variable win 0x0052c8e0 ECX

    namenParam→nClientId
  9. Rename variable win 0x0051e440 Stack[0x8]

    namedwParam→nNumberOfBytesToWrite
  10. Rename variable win 0x0042b990 ECX

    namenParam3→nAdler1
  11. Rename variable win 0x0042b990 EDX

    namenParam2→nAdler2
  12. Rename variable win 0x0042b990 Stack[0x4]

    namenParam1→nLen2
  13. Rename variable win 0x0042b9b0 ECX

    namenParam3→nAdler1
  14. Rename variable win 0x0042b9b0 EDX

    namenParam4→nAdler2
  15. Rename variable win 0x0042b9b0 Stack[0x4]

    namenParam1→nLen2Lo
  16. Rename variable win 0x0042b9b0 Stack[0x8]

    namenParam2→nLen2Hi
  17. Rename variable win 0x0042dbc0 ECX

    namenParam1→dwCrc
  18. Rename variable win 0x0042dbc0 EDX

    namenParam2→dwFinalXor
  19. Rename variable win 0x0042dbe0 ECX

    namenParam1→dwCrc
  20. Rename variable win 0x0042dbe0 EDX

    namenParam2→dwFinalXor