Proposals / #692

Name forwarded parameters in skill, AI and save functions

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

Each parameter reaches a named callee parameter unchanged, and I checked the pushes and registers against the callee's signature in the machine code. Names follow the callee, except PLRSAVE_LoadItemsFromBuffer's nFormat, which matches the nFormat proposed for the other save loaders, since its callee's eFormat is a uint32_t, and SERVER_IsItemOnCursor's dwItemGUID, because the call passes unit type 4 beside it. This replaces #670, which also took ITEMMOD_RollMagicAffixVersioned's EDX name from a callee name that turned out to be wrong.

Changes 7, applied together

1. Rename variable win 0x005de6d0 Stack[0x8]

   namenParam4→nXOffset

2. Rename variable win 0x005de6d0 Stack[0xc]

   namenParam5→nYOffset

3. Rename variable win 0x005490e0 Stack[0x8]

   namedwParam→dwItemGUID

4. Rename variable win 0x0056e2f0 EDX

   namenParam→eState

5. Rename variable win 0x0056cd50 Stack[0xc]

   namenParam2→nSkillLvl

6. Rename variable win 0x005de440 Stack[0xc]

   namenParam→nUnitMode

7. Rename variable win 0x0056a7e0 Stack[0xc]

   namenParam→nFormat