Proposals / #694

Name forwarded parameters in skill, monster AI, tile and draw functions

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

Each parameter reaches a named callee parameter unchanged, and I checked the pushes and registers against the callee's signature in the machine code. Names follow the callee, except nDuration on SKILLDRUID_ApplyTimedAuraBuff, which matches the name its sibling callee gives the same value and its own plate's expiry sum, and nFrameNumber on MINIPANEL_DrawButton, which is the D2GfxDataStrc field it fills. On MONSTERAI_CommandWalkToUnitWithCombat the chosen bySkillMode reaches ApplyCombatAndMonStats's nSteps. This replaces #679, which also named ITEMMOD_RollMagicAffixVersionedEx's parameters; those go in their own proposal now.

Changes 18, applied together

1. Rename variable win 0x0056bc80 Stack[0xc]

   namenParam2→nRadius

2. Rename variable win 0x005c7db0 Stack[0x10]

   namenParam→nSkillLvl

3. Rename variable win 0x005c7b10 Stack[0x10]

   namenParam1→nDuration

4. Rename variable win 0x005c7b10 Stack[0x18]

   namenParam2→nSkillLvl

5. Rename variable win 0x005de490 Stack[0xc]

   namenParam→nUnitMode

6. Rename variable win 0x005ecbc0 Stack[0xc]

   namenParam→nPathType

7. Rename variable win 0x00463bc0 Stack[0x4]

   namenParam1→nX

8. Rename variable win 0x00463bc0 EBX

   namenParam2→nY

9. Rename variable win 0x00604ae0 Stack[0x8]

   namenParam2→nTileType

10. Rename variable win 0x00604ae0 Stack[0xc]

    namenParam3→nTileSubType

11. Rename variable win 0x0047e860 Stack[0x4]

    namenParam1→nFrameNumber

12. Rename variable win 0x0047e860 Stack[0x8]

    namenParam2→nPositionX

13. Rename variable win 0x0047e860 Stack[0xc]

    namenParam3→nPositionY

14. Rename variable win 0x00452510 EDX

    namenParam1→nFontId

15. Rename variable win 0x00452510 Stack[0x4]

    namenParam2→nX

16. Rename variable win 0x00452510 Stack[0x8]

    namenParam3→nY

17. Rename variable win 0x00452510 Stack[0xc]

    namenParam4→nAlignment

18. Rename variable win 0x00452510 Stack[0x10]

    namenParam5→nCustomField