Proposals / #702

Name parameters that already have a pointer type, by the role the body shows

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-01

Ghidra v1799 · 2663303

These parameters already have a pointer or struct type but a generic name, so this renames them only. Each name comes from the struct fields the body reads or from the callee parameter it reaches. Least proven: pControl on the three MAINMENU handlers, whose bodies only null-check it, so that name rests on the existing type; pOwner, from SKILLASS_EquipSummonItems's plate and one inventory read; pRect, from four ints written through it. The chosen pModuleRequest on WARDEN_DownloadModule's third parameter looks wrong: [EBP+0x10] is pushed as pfnCacheWriteData's nSize. Left out as unread or unsettled: OOGUTIL_ProcessGameListEntry, MAINMENU_Unused16, SFILE_CloseStream1 to 5.

Changes 24, applied together

1. Rename variable win 0x00515c30 ECX

   namenParam→pSound

2. Rename variable win 0x005159b0 ECX

   namenParam→pSound

3. Rename variable win 0x00515a60 ECX

   namenParam→pSound

4. Rename variable win 0x006b10d0 Stack[0x4]

   namenParam→pCmp

5. Rename variable win 0x006b1290 Stack[0x4]

   namenParam→pCmp

6. Rename variable win 0x006b1210 Stack[0x4]

   namenParam→pCmp

7. Rename variable win 0x006b0430 Stack[0x4]

   namenParam→pDcmp

8. Rename variable win 0x00526540 ECX

   namenParam1→wszFirst

9. Rename variable win 0x00526540 EDX

   namenParam2→wszSecond

10. Rename variable win 0x005262f0 ECX

    namenParam→pCodePoint

11. Rename variable win 0x00527be0 EDX

    namenParam→wszSource

12. Rename variable win 0x005d6b60 EDX

    namenParam1→pOwner

13. Rename variable win 0x004c7c40 EDX

    namenParam1→pEventUnit

14. Rename variable win 0x004dc110 EDX

    namedwParam1→pEventUnit

15. Rename variable win 0x00619c40 Stack[0x4]

    namedwParam2→pRoom

16. Rename variable win 0x00619c40 Stack[0x8]

    namedwParam3→pRect

17. Rename variable win 0x00435030 Stack[0x4]

    namenParam→pControl

18. Rename variable win 0x004361b0 Stack[0x4]

    namenParam→pControl

19. Rename variable win 0x00436910 Stack[0x4]

    namenParam→pControl

20. Rename variable win 0x0047ffb0 Stack[0x4]

    namedwParam1→szKey

21. Rename variable win 0x0047ffb0 Stack[0x8]

    namedwParam2→pData

22. Rename variable win 0x004b6a30 ECX

    namedwParam→pUserParam

23. Rename variable win 0x00601450 Stack[0x8]

    namedwParam→pPaletteRemap

24. Rename variable win 0x006b58a0 EDX

    namedwParam→ppTexture