Proposals / #713

Retype UNITS_CheckSkillTargetAlignment's pnParam to D2UnitStrc *

stale · by Captain-Fwiffo · submitted 2026-11-01

Already applied: at v1801 the EDX parameter of 005542c0 is D2UnitStrc *, not int *, so the expect no-longer matches. The leftover pnParam name could get a rename to pUnit in a separate proposal.

The EDX parameter is the casting/owning unit: the body tests [0] == 0 (eUnitType == UNIT_PLAYER) and compares [3] (+0xc, nUnitGUID) with the target's owner GUID. Its two callers pass units: SKILLS_ValidateSkillTarget passes its D2UnitStrc * pUnit (EDX = [EBP+0xc] at 0x0056ccc0, its second stack parameter) and Missiles_SrvHitFunc_HealTarget passes EBX, the D2UnitStrc * returned by GetOwnerUnit (0x005aa021, call at 0x005aa018). Same-width retype; name kept.

Changes 1, applied together

1. Retype variable win 0x005542c0 EDX

   typeint *→D2UnitStrc *