Proposals / #716

Name skill setter, missile, aura and player mode parameters

applied · by dtchitt · submitted 2026-11-01, applied 2026-11-02

Ghidra v1805 · 8293ab3

SKILL_SetParam1 to 4 take the D2SkillStrc fields they write. CreatingAMissile and SKILLS_CreateMissileFromUnit take names from the D2SkillArgStrc fields they fill: the offsets are added to the owner's position, and the target pair goes to sSkillArg.nUnitX and nUnitY. D2SetAurastatsFromSkills reaches D2GetSkillCalc's nSkillLvl. The two PLRMODES functions skip TryCancelModeAndMoveToLocation when the flag is nonzero. SKILLNEC_ReviveCorpseAsMinion adds its parameter to 3/4 of the caster level. Not proven: bConsumeAmmo beyond its gate on RemoveQuanityOnUse, and bSkipCancelAttempt is the observed effect only. Chosen names that look wrong: nX and nY on PLRMODES_TryCancelModeAndMoveToLocation 0057eec0, whose callers pass the mode index and the constant 1 there.

Changes 19, applied together

1. Rename variable win 0x00644560 Stack[0x8]

   namenParam1→nPar1

2. Rename variable win 0x006445a0 Stack[0x8]

   namenParam2→nPar2

3. Rename variable win 0x006445e0 Stack[0x8]

   namenParam3→nPar3

4. Rename variable win 0x00644620 Stack[0x8]

   namenParam4→nPar4

5. Rename variable win 0x0056ecb0 Stack[0x10]

   namenParam1→nOffsetX

6. Rename variable win 0x0056ecb0 Stack[0x14]

   namenParam2→nOffsetY

7. Rename variable win 0x0056ecb0 Stack[0x18]

   namenParam3→nTargetX

8. Rename variable win 0x0056ecb0 Stack[0x1c]

   namenParam4→nTargetY

9. Rename variable win 0x0056ecb0 Stack[0x20]

   namenParam5→bConsumeAmmo

10. Rename variable win 0x0056ee90 Stack[0xc]

    namenParam1→nSkillLvl

11. Rename variable win 0x0056ee90 Stack[0x10]

    namenParam2→nOffsetX

12. Rename variable win 0x0056ee90 Stack[0x14]

    namenParam3→nOffsetY

13. Rename variable win 0x0056ee90 Stack[0x18]

    namenParam4→nTargetX

14. Rename variable win 0x0056ee90 Stack[0x1c]

    namenParam5→nTargetY

15. Rename variable win 0x0056ee90 Stack[0x20]

    namenParam6→bConsumeAmmo

16. Rename variable win 0x005c6cc0 Stack[0xc]

    namenParam→nSkillLvl

17. Rename variable win 0x005809d0 Stack[0x14]

    namenParam→bSkipCancelAttempt

18. Rename variable win 0x00580a70 Stack[0x14]

    namenParam→bSkipCancelAttempt

19. Rename variable win 0x005c49e0 Stack[0xc]

    namenParam2→nLevelOffset