Proposals / #749

Mac: type pLevel as D2DrlgLevelStrc * in the four DRLGMAZE_Find{Top,Bottom,Left,Right}MostRoom helpers

applied · by Captain-Fwiffo · submitted 2026-11-01, applied 2026-11-02

Ghidra vmac 108 · bc4e150

All four Mac helpers take the level as an int and walk its room list: they start from level+0x10 (D2DrlgLevelStrc.pRoomExFirst), follow room+0x24 (D2RoomExStrc.pRoomExNext) and compare room+0x34 / +0x38 (sCoords world x / y). Same-width retypes of the one parameter in each; names kept. FindTopMostRoom is __fastcc (the level is in ECX), the other three are __cdecl. Windows twins (006723e0 / 006724a0 / 00672420 / 00672460) are named in each Mac function's comment. Return values and the pRoomEx/pBestRoom locals are not touched. Mac callers were not traced.

Changes 4, applied together

1. Retype variable mac 0x0015333f Stack[0x4]

   typeint→D2DrlgLevelStrc *

2. Retype variable mac 0x001533c1 ECX

   typeint→D2DrlgLevelStrc *

3. Retype variable mac 0x00153b48 Stack[0x4]

   typeint→D2DrlgLevelStrc *

4. Retype variable mac 0x00153b83 Stack[0x4]

   typeint→D2DrlgLevelStrc *