Proposals / #773

Mac: retype SUNITNPC_OpenTradeScreen's pPlayer to D2UnitStrc *

applied · by Captain-Fwiffo · submitted 2026-11-01, applied 2026-11-02

Ghidra vmac 108 · bc4e150

Mac twin of the Windows SUNITNPC_OpenTradeScreen(SGAMEDATA *, D2UnitStrc * pPlayer, ...) at 00579360, already typed there. The Mac body reads pPlayer+0xc (D2UnitStrc.nUnitGUID) to match the NPC's per-player inventory node and forwards pPlayer to SUNITPROXY_AddPlayerInteraction as a D2UnitStrc * (the decompile shows a (D2UnitStrc *)pPlayer cast). Same-width retype of the second stack parameter; name kept. Mac callers were not traced.

Changes 1, applied together

1. Retype variable mac 0x0028b849 Stack[0x8]

   typeint32_t→D2UnitStrc *