Proposals / #793

Type Mac any-hostile roster predicate return

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra vmac 110 · 9528519

Mac ROSTER_CheckAnyPlayerHostileToMe has undefined4 return metadata. Its complete94-byte native body explicitly writes full EAX1 after a nonzero GetFlag result, or full EAX0 when roster traversal exhausts, including an empty list. All three direct UI callers test full EAX. Use existing four-byte BOOL; preserve selected function name, zero formals and cdecl. This is own native normalization, independent of any assumed helper semantics: GetFlag output is tested opaque, not returned as mask8. Current typed roster head, GUID/next fields, local-player GUID/-1 fallback and outgoing mask8 stores match complete body. Full target, three callers, unit getter and flag helper raw memory(1307bytes) independently match separate assembly; all9 repair-caller PIC switch targets and return reaching definitions checked. No parameter/name/storage/layout/helper changes or Windows ABI/runtime/build claim.

Changes 1, applied together

1. Set prototype mac 0x0007615e

   signatureundefined4 ROSTER_CheckAnyPlayerHostileToMe(void)→BOOL ROSTER_CheckAnyPlayerHostileToMe(void)
   convention__cdecl