Proposals / #797

Type the two roster packet handlers' argument as their packet structs

applied · by dtchitt · submitted 2026-11-02, applied 2026-11-02

Ghidra v1809 · 41c2819

Resubmit of #655 with the types the review asked for. NET_D2GS_CLIENT_Incoming0x65 and 0x8D read a dword at +1 and a word at +5, which are exactly D2GSPacketSrv0x65 (dwUnitGUID, wKillCount) and D2GSPacketSrv0x8D (nUnitGUID, nPartyId). Both sit in the client's packet handler table, and the dispatcher calls those slots with the packet bytes.

Changes 4, applied together

1. Rename variable win 0x0045e6b0 ECX

   namenParam→pPacket

2. Retype variable win 0x0045e6b0 ECX

   typeint32_t→D2GSPacketSrv0x65 *

3. Rename variable win 0x0045ea90 ECX

   namenParam→pPacket

4. Retype variable win 0x0045ea90 ECX

   typeint32_t→D2GSPacketSrv0x8D *