Proposals / #801

Name the gamma parameter of the skill draw helpers, plus forwarded thunk parameters (resubmit)

applied · by dtchitt · submitted 2026-11-02, applied 2026-11-02

Ghidra v1809 · 41c2819

Resubmit of #704, approved and then gone stale only on the one op #594 already applied, which is dropped here. SKILL_DrawUnitAtRotatedAngle's EDX reaches DRAW_WORLD_Unit_1's nGamma. The two PLRSKILLS wrappers pass EDX on to that helper and to SKILL_DrawChargeTrail. The rest are forwarded unchanged and follow the callee, except nRequestHandle on SFILE_CancelAsyncRequestWithStatus, whose plate calls the value the request's handle.

Changes 7, applied together

1. Rename variable win 0x004c9060 EDX

   namenParam→nGamma

2. Rename variable win 0x004d8520 EDX

   namenParam→nGamma

3. Rename variable win 0x004d85c0 EDX

   namenParam→nGamma

4. Rename variable win 0x00557fc0 EAX

   namedwParam→pArgs

5. Rename variable win 0x0051b1b6 CL

   namebParam→nPacketId

6. Rename variable win 0x0052b640 DX

   namenParam→nSize

7. Rename variable win 0x0041a960 Stack[0x4]

   namenParam→nRequestHandle