Proposals / #833

Name the stat list flags parameter dwFlags across the ITEMPROP_ family

applied · by jaenster · submitted 2026-11-02, applied 2026-11-02

Ghidra v1809 · 9528519

Stack[0x20] is the 10th slot of the shared fpProperties signature. ITEMPROP_AddStat_Simple puts it in EDX at 0065f2ed from [EBP+0x24] and calls ITEMMOD_AddStatToItem (0065ea50) at 0065f2f5, so it arrives in the fastcall EDX parameter there, already carrying the chosen name dwFlags. That function forwards it as the 3rd argument of ITEMMOD_GetOrCreateStatList (0065cbf0), where the parameter is already named nFlags and is used only as flags: GetStatListByStateOrFlagsIfNotExists(pUnit, nState, nFlags) and AllocStatList(pMemory, nFlags, 0, UNIT_ITEM, guid). The chosen callee function name GetStatListByStateOrFlagsIfNotExists corroborates it. ITEMPROP_AddStat_WithMaxDurabilityReset is left out: it already has the chosen name nStatLayer in this slot, which disagrees with the two callee names, so it is worth a reviewer's eye rather than a silent rename.

Changes 24, applied together

1. Rename variable win 0x0065eb30 Stack[0x20]

   namenParam22→dwFlags

2. Rename variable win 0x0065eba0 Stack[0x20]

   namenParam4→dwFlags

3. Rename variable win 0x0065ec10 Stack[0x20]

   namenParam22→dwFlags

4. Rename variable win 0x0065ec80 Stack[0x20]

   namenParam5→dwFlags

5. Rename variable win 0x0065ecf0 Stack[0x20]

   namenParam22→dwFlags

6. Rename variable win 0x0065ee80 Stack[0x20]

   namenParam22→dwFlags

7. Rename variable win 0x0065f010 Stack[0x20]

   namenParam22→dwFlags

8. Rename variable win 0x0065f2b0 Stack[0x20]

   namenParam5→dwFlags

9. Rename variable win 0x0065f310 Stack[0x20]

   namenParam5→dwFlags

10. Rename variable win 0x0065f390 Stack[0x20]

    namenParam5→dwFlags

11. Rename variable win 0x0065f3f0 Stack[0x20]

    namenParam5→dwFlags

12. Rename variable win 0x0065f470 Stack[0x20]

    namenParam4→dwFlags

13. Rename variable win 0x0065f590 Stack[0x20]

    namenParam3→dwFlags

14. Rename variable win 0x0065f6a0 Stack[0x20]

    namenParam3→dwFlags

15. Rename variable win 0x0065f870 Stack[0x20]

    namenParam3→dwFlags

16. Rename variable win 0x0065f960 Stack[0x20]

    namenParam4→dwFlags

17. Rename variable win 0x0065f9d0 Stack[0x20]

    namenParam4→dwFlags

18. Rename variable win 0x0065fa40 Stack[0x20]

    namenParam4→dwFlags

19. Rename variable win 0x0065fae0 Stack[0x20]

    namenParam3→dwFlags

20. Rename variable win 0x0065fb50 Stack[0x20]

    namenParam22→dwFlags

21. Rename variable win 0x0065fba0 Stack[0x20]

    namenParam4→dwFlags

22. Rename variable win 0x0065fbf0 Stack[0x20]

    namenParam4→dwFlags

23. Rename variable win 0x0065fc40 Stack[0x20]

    namenParam4→dwFlags

24. Rename variable win 0x0065fd20 Stack[0x20]

    namenParam3→dwFlags